[rb] Add rubocop binary target for flexible linting#17006
Closed
titusfortner wants to merge 1 commit intotrunkfrom
Closed
[rb] Add rubocop binary target for flexible linting#17006titusfortner wants to merge 1 commit intotrunkfrom
titusfortner wants to merge 1 commit intotrunkfrom
Conversation
Contributor
User description💥 What does this PR do?Adds a flexible 🔧 Implementation Notes
💡 Additional ConsiderationsThis matches the pattern I've been using with ruff and format 🔄 Types of changes
PR TypeEnhancement Description
Diagram Walkthroughflowchart LR
A["rb/BUILD.bazel"] -->|adds| B["rubocop binary target"]
A -->|removes| C["lint-unsafe target"]
B -->|accepts| D["custom rubocop flags"]
C -->|replaced by| B
|
| Relevant files | |||
|---|---|---|---|
| Enhancement |
|
selenium-ci
added
C-rb
Contributor
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a flexible //rb:rubocop binary target that allows passing arbitrary rubocop flags via --, and removes the now-redundant //rb:lint-unsafe target. This provides better flexibility for running rubocop with custom options while maintaining the existing //rb:lint test target unchanged.
Changes:
- Added
//rb:rubocopbinary target that accepts arbitrary rubocop flags - Removed
//rb:lint-unsafebinary target (no longer needed)
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Member
Author
|
fixed and merged into trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
Adds a flexible
//rb:rubocopbinary target that accepts any rubocop flags,and removes the now-redundant
//rb:lint-unsafetarget.🔧 Implementation Notes
//rb:rubocopincludes only the config and file paths, letting you pass any flags via--bazel run //rb:rubocop -- --autocorrect-all(replaces//rb:lint-unsafe)bazel run //rb:rubocop -- --only Metrics/AbcSizebazel run //rb:rubocop -- --auto-gen-config//rb:lintunchanged - still runs as a test with--autocorrect💡 Additional Considerations
This matches the pattern I've been using with ruff and format
🔄 Types of changes